Task description is overwritten when pressing ESC key

Bug
1

Hey. I’ve encountered a problem with restoring the description field content when using the search function. How to reproduce this bug:

  1. Search for a task and open it
  2. Search for another task and open it
  3. Edit the description
  4. Cancel the Description with escape key on keyboard
  5. the description of the previous task will be saved for the current task

Just lost my whole ticket and had to restore a backup :headstone: :sweat_smile:

Vikunja v0.24.2

2

I run latest unstable, I cannot reproduce, have you tested this on try?

3

just tried it on try and can reproduce it there. maybe browser dependent? I’m using Firefox.

4


Using Arc Browser, is the video above correct in the reproduce steps?

5

can confirm Firefox has this issue, but a page refresh took care of it:

6

Yeah this looks like a bug.

It is part of a feature where the description is reset to the previous state when you press esc. Do you think that’s a problem in general? Maybe we should just lose the focus and save, similar to when you click save or press ctrl enter.

7

No, I think it’s a nice feature in general. I use it quite often, especially when accidentally switching into the edit mode and want to reassure that I haven’t changed anything.

8

Should be fixed in acc7c9f8f5, please check with the next unstable build (should be ready for deployment in ~45min, also on try).

9

It’s fixed! Thanks! :+1:

10

How to know whether this commit is present in the release v0.24.6?

Excuse me if this question seems dumb, using Vikunja for few days now. I found this issue because I had a task opened for a few hours, editing and saving it multiple times… Then I clicked Edit and not changed anything (changed just my mind), so the SAVE button was disabled. So I pressed ESC to “cancel the edit” and the task description was reverted to initial state when I last opened it hours ago :exploding_head: and Undo/Redo functions also had no effect of restoring my changes.

11

That sounds like the fix is not in 0.24.6. You could switch to an unstable release, that should have it (try runs on unstable).

12

Happened again today on v0.24.1-812-2d8fb8bad9, pressing ESC multiple times reverts the page to the last refresh state, without option to redo the changes.

However, when I wanted to reproduce it on a newly created task where I could “afford” to lose the changes, I could not. I will try to find what is causing it. Do you recommend enabling or observing any specific logs, to make the detection easier?