Comment order is not by time?

Freundschaft · 10 February 2023 02:26

it seems like comments on tasks are not sorted by creation time, what is the sort order and how can it be changed? Thanks!

kolaente · 10 February 2023 14:47

They should be sorted by creation time, just the last task at the bottom.

Right now there’s no way to change the order.

Freundschaft · 29 August 2023 09:33

ok somehow something is wrong with this, at the moment it seems like the comment order is a bit random

Freundschaft · 29 August 2023 09:38

I think probably it would already be sufficient to sort by the id or created/updated field here:

github.com

go-vikunja/api/blob/693a77ae5181648876bc8bb470834b20b37d37bd/pkg/models/task_comments.go#L271


      
          	if err != nil {
          		return
          	}
          
          	for _, comment := range comments {
          		comment.Author = authors[comment.AuthorID]
          	}
          
          	numberOfTotalItems, err = s.
          		Where("task_id = ? AND comment like ?", tc.TaskID, "%"+search+"%").
          		Count(&TaskCommentWithAuthor{})
          	return comments, len(comments), numberOfTotalItems, err
          }

what do you think?

kolaente · 29 August 2023 12:07

@Freundschaft That sounds like a different issue. The fix you suggested should work, I’ll check.

kolaente · 29 August 2023 12:10

Should be fixed in 5392ca788c - please check with the next unstable build.

Freundschaft · 30 August 2023 12:36

Perfect, thanks a lot!

I tried running the unstable build but received these logs on the API server:

2023-08-30T12:32:00.004852947Z: ERROR   ▶ models/func1 0c0 [Undone Overdue Tasks Reminder] Could not get undone overdue tasks in the next minute: pq: column "list_id" does not exist
2023-08-30T12:32:05.820126349Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/info 177.821µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:32:05.866446308Z: ERROR   ▶ v1/UserShow 0c4 pq: column "default_list_id" does not exist
2023-08-30T12:32:05.866544178Z: WEB     ▶ 10.66.246.17  GET 500 /api/v1/user 3.906246ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:32:06.096231826Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 4.82296ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:32:08.295349824Z: WEB     ▶ 10.66.246.17  GET 400 /api/v1 45.12µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:32:11.694501654Z: WEB     ▶ 10.66.246.17  GET 404 /api/ 28.331µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:32:16.119616466Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 10.553246ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:32:26.111007418Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 4.122448ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:32:36.119722575Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 9.900583ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:32:46.493854172Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 9.24707ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:32:56.52139213Z: WEB      ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 12.552475ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:00.004064498Z: ERROR   ▶ models/func1 0d3 [Undone Overdue Tasks Reminder] Could not get undone overdue tasks in the next minute: pq: column "list_id" does not exist
2023-08-30T12:33:06.910844513Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 4.60377ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:14.569851293Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/info 289.222µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.62
2023-08-30T12:33:14.683360741Z: ERROR   ▶ v1/UserShow 0d9 pq: column "default_list_id" does not exist
2023-08-30T12:33:14.683424041Z: WEB     ▶ 10.66.246.17  GET 500 /api/v1/user 6.153587ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.62
2023-08-30T12:33:16.909575045Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 5.367714ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:24.686753122Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/info 211.461µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.62
2023-08-30T12:33:24.814717963Z: ERROR   ▶ v1/UserShow 0dd pq: column "default_list_id" does not exist
2023-08-30T12:33:24.814817033Z: WEB     ▶ 10.66.246.17  GET 500 /api/v1/user 6.608808ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.62
2023-08-30T12:33:26.912504634Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 5.374793ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:36.936930366Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 12.594444ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:46.926963421Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 3.281694ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:33:56.944666454Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 9.559291ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:34:00.010150498Z: ERROR   ▶ models/func1 0ea [Undone Overdue Tasks Reminder] Could not get undone overdue tasks in the next minute: pq: column "list_id" does not exist
2023-08-30T12:34:06.948549177Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 5.255782ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:34:16.968312249Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 16.12972ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:34:26.977134194Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 11.62219ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:34:34.71240896Z: WEB      ▶ 10.66.246.17  GET 404 /api/ 27.42µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:34:36.269555897Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/info 210.111µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:34:36.312256341Z: ERROR   ▶ v1/UserShow 0f2 pq: column "default_list_id" does not exist
2023-08-30T12:34:36.312355362Z: WEB     ▶ 10.66.246.17  GET 500 /api/v1/user 1.670358ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:34:36.971952989Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 3.813726ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0
2023-08-30T12:34:39.785130507Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/info 185.651µs - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:34:39.842056062Z: ERROR   ▶ v1/UserShow 0f6 pq: column "default_list_id" does not exist
2023-08-30T12:34:39.842132172Z: WEB     ▶ 10.66.246.17  GET 500 /api/v1/user 6.354897ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
2023-08-30T12:34:46.994594132Z: WEB     ▶ 10.66.246.17  GET 200 /api/v1/notifications?page=1 6.87409ms - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

kolaente · 30 August 2023 17:49

Can you check if all migrations were run? The last one should be 20230828125443

Even if, the error should not be happening I assume you upgraded from a stable release with data?

Freundschaft · 30 August 2023 18:31

Yes, and when i downgraded again thinks were fine again
I also went inside the api container and ran vikunja migrate.

kolaente · 31 August 2023 09:45

Which exact version did you run? There should be a message stating the exact version (with git hash) on startup of the api container.

The error looks like you ran an old version, maybe you didn’t pull the latest unstable image?

Freundschaft · 31 August 2023 11:50

ah yes whoops, now it works thanks!

Freundschaft · 31 August 2023 12:54

sorry for all the deleted posts, I just now realized the latest unstable build doesnt contain the fix yet, as some tests seem to be failing on the pipeline at Drone CI
Ill wait until the image is online and will then test and report back

kolaente · 31 August 2023 15:10

Should be fixed now, please check the last unstable build again.

Freundschaft · 31 August 2023 16:13

perfect, works now! Just maybe, instead of id ASC, id DSC could be better, as now the oldest comment is on top, while probably its better to have the most recent comment on top and then gradually descending to the olds from top to bottom, what do you think?

kolaente · 3 September 2023 11:58

My reasoning for the order was that you’ll probably want to relpy to the last comment and thus want to see it when you reply. I’ve seen both ways of ordering it in other tools though, might be worthwhile to make this configurable.