Email links when "publicurl" is set to array datatype

Feature Discussion
1

Hi,

A while ago I posted that I had successfully set the “publicurl” config item to an array to allowing using alternate domain name(s). See this topic.

However, I’ve found that at least one price for this is that the emailed links no longer work; they simply have the format “tasks/180”, with no protocol or domain. Presumably that’s because the code that forms the url expects a string value for publicurl, rather than array, and returns null.

So, after running “multiple domain” values for publicurl for several weeks, this is the only issue I’ve run into. I’m wondering if it would be considered worth “fixing”. I imagine it is pretty minor, but (1) I know nothing of “go” and (2) I’ve never done a PR before.

So I thought I’d ask if this is minor enough for someone to do without significant inconvenience or, if it is considered worthwhile, I could take some time to learn what I need to do this; probably setting up the dev environment would be the biggest obstacle for me.

Thanks in advance for your input / advice!!!

2

This would touch on a lot of things, which makes this rather complicated. I’d recommend setting the public URL to only one value and adding the other URLs as cors endpoints instead.

Vikunja does not validate the URL you access it from, it just uses the configured public URL to load assets and for email links.